Tristan Rice

Results 128 comments of Tristan Rice

you'll have to unpin ray version as well https://github.com/pytorch/torchx/commit/b70811e11ed4ed5d3b9dca62f177177135b7990f

@ljjsalt you can just change that type to "object" since we don't actually interact with it (just pass it back to Ray) and it seems like those ray methods are...

ah yeah -- that probably wasn't quite the right thing to do -- looks like you were missing some local dependencies. Did you install all of dev-requirements.txt? Are you running...

Yeah -- would be. Just allows for different types of images/patching with the same scheduler

@takeshi-yoshimura there's a balance here -- not sure how hard it is to install the lsf library. If it's painful maybe that's not the best option

@takeshi-yoshimura what's your plans for updating this pr? We'd like to include it but still needs some polish

If lsf-python-api isn't in a good shape there's no strong need to use it then. That was my concern when I looked at it before so glad you have the...

@takeshi-yoshimura Think the main thing blocking this particular diff is just adding some comprehensive unit tests (and fixing lint/pyre)

@takeshi-yoshimura The biggest current gap right now is workspaces. Having support for the DockerWorkspace to allow patching the images before launching the job would be very nice if you want...

The CI is failing on both of them which is why I haven't merged -- #587 is a bit closer to being ready to land