Tristan Rice

Adding in some logic to apply the patch to all roles that share an image seems very reasonable @kurman is this something that can be applied to all workspaces or...

Looks like there's also valid pyre/lint issues

@Bobbins228 there's been a bunch of cleanup on tests in on the `main` branch -- if you rebase/merge all tests should be passing (assuming no new breaking changes)

@xujyan @Bobbins228 looks like the ddp job on Kueue is having issues

@ccharest93 are you interested in polishing this up and landing it? cc @clumsy

https://docker-py.readthedocs.io/en/stable/api.html#docker.api.build.BuildApiMixin.build

Ah nice, just saw that I recently ran into this issue and well On Wed, Feb 28, 2024, 11:12 Maatra ***@***.***> wrote: > Yeah the PR is written #815 >...

@kiukchung looks like this PR introduced a issue in the doctest build https://github.com/pytorch/torchx/actions/runs/8456379306/job/23166027094

@anjali-chadha does the index-url change depending on where it's being built from? I'm curious why you don't add the index to the Dockerfile. Another option could be to save it...

cc @Sara-KS for the mcad changes -- should be a no-op, just moving image_repo opt to pull from the DockerWorkspaceMixin