torchx
torchx copied to clipboard
Support Ray 2.0
Signed-off-by: Amog Kamsetty [email protected]
Remove usage of ray.train.utils.get_address_and_port
to support recent changes in Ray 2.0
Closes https://github.com/pytorch/torchx/issues/584
Test plan:
Hi @amogkam!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Is this ready to be merged in?
Seems like #587 also includes a Ray 2.0 fix? I'll let @d4l3k decide what to merge
The CI is failing on both of them which is why I haven't merged -- #587 is a bit closer to being ready to land
@kurman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.