torchx icon indicating copy to clipboard operation
torchx copied to clipboard

Support Ray 2.0

Open amogkam opened this issue 2 years ago • 5 comments

Signed-off-by: Amog Kamsetty [email protected]

Remove usage of ray.train.utils.get_address_and_port to support recent changes in Ray 2.0

Closes https://github.com/pytorch/torchx/issues/584

Test plan:

amogkam avatar Aug 23 '22 18:08 amogkam

Hi @amogkam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 23 '22 18:08 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Aug 23 '22 20:08 facebook-github-bot

Is this ready to be merged in?

amogkam avatar Aug 26 '22 17:08 amogkam

Seems like #587 also includes a Ray 2.0 fix? I'll let @d4l3k decide what to merge

msaroufim avatar Sep 01 '22 23:09 msaroufim

The CI is failing on both of them which is why I haven't merged -- #587 is a bit closer to being ready to land

d4l3k avatar Sep 02 '22 00:09 d4l3k

@kurman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Oct 10 '22 19:10 facebook-github-bot