Damien Alleyne
Damien Alleyne
Hi @jrfnl 👋🏽 . I have started investigating this issue by setting up a test environment and reviewing the relevant code, particularly the [$allowedFunctionsList](https://github.com/WordPress/WordPress-Coding-Standards/blob/7722c0b8a6f4eb615be4ba8ebe22ed92a5fa87d7/WordPress/Sniffs/PHP/NoSilencedErrorsSniff.php#L86) in `NoSilencedErrorsSniff.php`. I notice that in...
@jrfnl Do you mean something like [this](https://3v4l.org/7GHnS), but documented for all functions in `$allowedFunctionsList`?
@jrfnl My plan is to run these functions in both on PHP7 and PHP8, and document any differences, if any. In our existing example, it'd look like this. e.g. |...
Great idea, will do!
| Function | Link | Remarks | |----------|------|---------| | [chdir](https://www.php.net/manual/en/function.chdir.php) | [https://3v4l.org/l3jFs#veol](https://3v4l.org/l3jFs#veol) | Behaviour unchanged | | [opendir](https://www.php.net/manual/en/function.opendir.php) | [https://3v4l.org/DoMVG#veol](https://3v4l.org/DoMVG#veol) | Behaviour unchanged | | [scandir](https://www.php.net/manual/en/function.scandir.php) | [https://3v4l.org/vf62L#veol](https://3v4l.org/vf62L#veol) | Behaviour...
@jrfnl I've observed that PHP 8.0 throws errors when there's a type mismatch in function arguments, for instance, passing an array where a string is expected. Should we classify these...
> I don't see a problem with upgrading ts, versions are non-conflict. For small personal projects, upgrading is easy. For large projects, upgrading is challenging. I tried upgrading from TS...
I will discuss this issue with a teammate to determine if there is an alternative solution to reverting [#45775](https://github.com/WordPress/gutenberg/pull/45775).
We have concluded that reverting is the best approach for now.
@YordanSoares do you have an idea of how this feature can be implemented? I see a few issues that appear to be duplicates of this one (#85 #82). Do we...