Aleksa Sarai

Results 789 comments of Aleksa Sarai

Damn, I missed this because it wasn't in the -rc.1 milestone. I guess we'll need to wait for 1.4.0-rc.1 before fixing this.

Previous discussion in runtime-spec: https://github.com/opencontainers/runtime-spec/pull/1259

Moved the milestone to 1.3.0. Dealing with this is going to take a while, and we should just get 1.2.0 out (this is a pre-existing issue anyway).

This completely dropped off my radar. We can try to consider this a bugfix for 1.3.0, or fix it in 1.4.0-rc.1 and see if it's worth backporting the fix.

Forgot about this again -- moving to 1.5.

@kolyshkin Am I correct with understanding that with opencontainers/runtime-spec#1262 merged, runc's behaviour is correct and we no longer need any PRs to fix this (including #4348)?

My understanding is we can close it, I was hoping to get confirmation from @kolyshkin first since he did the spec PRs.

Yeah, looking at https://github.com/opencontainers/runc/pull/4348#discussion_r1679586846 again, I think I misremembered the error case as being the main point of contention. We can probably carry the PR...

This won't be able to make it in 1.4.0 at this point, so I'll slate it for 1.5. I'll sit down and do the backport in the coming weeks so...

You can't make private forks, so we had to make a copy. AFAICS you can't disable dependabot if there is a config file in the repo. At the bottom of...