runc icon indicating copy to clipboard operation
runc copied to clipboard

fix runc's poststart behaviour doesn't match the runtime-spec

Open ningmingxiao opened this issue 1 year ago • 9 comments

fix:https://github.com/opencontainers/runc/issues/4347

ningmingxiao avatar Jul 15 '24 16:07 ningmingxiao

Please write a more detailed commit message. "fix poststart error" is not a good one.

kolyshkin avatar Jul 16 '24 01:07 kolyshkin

Please write a more detailed commit message. "fix poststart error" is not a good one.

done.thank you. please review my pr. @kolyshkin @cyphar

ningmingxiao avatar Jul 16 '24 03:07 ningmingxiao

already backport https://github.com/opencontainers/runc/pull/4351

ningmingxiao avatar Jul 17 '24 13:07 ningmingxiao

The commit description still doesn't say what it does and why.

kolyshkin avatar Jul 17 '24 22:07 kolyshkin

Moved the milestone to 1.3.0. Dealing with this is going to take a while, and we should just get 1.2.0 out (this is a pre-existing issue anyway).

cyphar avatar Oct 21 '24 07:10 cyphar

A draft until opencontainers/runtime-spec#1262 is decided on

kolyshkin avatar Feb 12 '25 17:02 kolyshkin

Damn, I missed this because it wasn't in the -rc.1 milestone. I guess we'll need to wait for 1.4.0-rc.1 before fixing this.

cyphar avatar Mar 01 '25 16:03 cyphar

The spec PR is not yet merged, moving to 1.4. Now to 1.4.0-rc.1, so hopefully you don't miss it @cyphar :)

rata avatar Apr 08 '25 09:04 rata

Ok thanks

ningmingxiao avatar Apr 08 '25 13:04 ningmingxiao