Aleksa Sarai

Results 785 comments of Aleksa Sarai

I'm not sure why it works with containerd 1.7, but this OOM issue with Kubernetes e2e tests is something we know about. This is caused by #4392 (backport of #3931)...

I'm not super familiar with Kubernetes e2e tests, but I believe `KubeReservedMemory` is setting the limits of the cgroup that containerd runs in (or something equivalent). See [`runOomKillerTest`](https://github.com/kubernetes/kubernetes/blob/95ec69c16c76b5ee71fdbebc7a5dea2c39341eb3/test/e2e_node/oomkiller_linux_test.go#L111): ```go func...

Maybe we can just backport the code that moved the copying logic rather than trying to come up with a bespoke fix for 1.1.x that isn't in 1.2.x? Or we...

@thaJeztah Your comments in #4557 on this topic would be appreciated :wink:. The current text in that PR implies that we are not _required_ to do 1.0.x or 1.1.x releases....

No rush, I just wanted to make sure you had a chance to give your input since you commented about this exact topic here. 😸

This is marked for 1.4.0 but I plan to cut -rc1 this week and there are still some outstanding points. Do we want to merge this as-is and fix it...

The `nolintlint` issue is quite annoying, I've hit it before as well. Adding `nolintlint` is the only way I found to work around it as well. The only real long-term...

This has 3 reviews, so I'm happy to merge it. @askervin Did you still want this in runc 1.4? @kolyshkin @AkihiroSuda @lifubang Would you be happy for us to add...

@lifubang I already did that in a0e809a8ba6a61e3f4490132ef169ac991281e0b (I pushed it to #4993).

Moved the milestone to 1.3.0. Dealing with this is going to take a while, and we should just get 1.2.0 out (this is a pre-existing issue anyway).