Lars Holmberg comments

Results 337 comments of


                                            Lars Holmberg

CLI argument for selecting `UserClasses` to run

Can we comment out the deprecation warning for now? I do want to deprecate it, but not yet :) On an unrelated note, I'm looking for endorsements/testimonials to put on...

CLI argument for selecting `UserClasses` to run

Can you update this test to use the new style: https://github.com/locustio/locust/blob/8a35d8de43797340b231161250550c7045f855fb/locust/test/test_main.py#L2205

Error Logging in FastHttpUser

PR:s welcome (I'll look at it myself, but no guarantees on the timing)

Error Logging in FastHttpUser

Ideally, make it work the same as HttpUser.

Error Logging in FastHttpUser

Interesting. But maybe even better/easier to subclass the ConnectionError class (in locust) and override the `__repr__` method there? Such a PR would be most welcome!

Error Logging in FastHttpUser

Looks great! PR it? Maybe add a test case for it? (ignore any other errors, the tests are a bit flaky atm)

FastHttpUser does not pass headers correctly during a retry after a "failure exception" such as timeout

Thanks for the deep analysis! We have a different ticket open for using geventhttpclient’s UserAgent https://github.com/locustio/locust/issues/2681 Do you think that would that solve this issue?

FastHttpUser does not pass headers correctly during a retry after a "failure exception" such as timeout

Yea the implementation in Locust was copied over to geventhttpclient (because it could be useful to others as well, not just Locust :)

Want iteration control and worker shutdown

Hi! locust-plugins offers something like that: https://github.com/SvenskaSpel/locust-plugins?tab=readme-ov-file#command-line-options

The locust chart shows that data is still being recorded after the timed run time expires

@andrewbaldwin44 and I are pretty busy at the moment. @PlanetartRoc 's fix looks promising (feel free to make a PR) and @zhenhuaplan second issue is also worth investigating.