Lars Holmberg

Results 237 comments of Lars Holmberg

+1 Only seems to happen for our most recent PR:s. The PR merged *before* the error appears has a lot of force pushes (https://github.com/locustio/locust/pull/1805), but other than that I dont...

Huh. It started working for me again. Maybe after I tagged master?

That's really the only thing I changed. I first pushed a commit directly to master (https://github.com/locustio/locust/commit/61b3c2808832c2735cbe17da69004a2787ca2eaf) but that didnt seem to do anything. But once I tagged that commit with...

I dont think my issue relates to the tagging itself (I dont think I've had to tag before creating the changelog before? I'm using the --future-release param), I think it...

Before tagging: ``` Found 63 tags Fetching tags dates: 63/63 Sorting tags... Received issues: 1771 Pull Request count: 636 Filtered pull requests: 420 Filtered issues: 798 Fetching events for issues...

Maybe the core issue is "not found in the release branch"? Those merge commits should definitely be in the release branch (master), but maybe the tag helped changelog generator find...

The more I think about it, the more that makes sense: It seems PR:s merged after the last tag arent found.

Yup, and now I merged another PR (without adding a tag), and the error is visible again (for that new PR). ``` github_changelog_generator -t ... -u locustio -p locust --exclude-labels...

Can you reproduce it? I'm kind of in a catch 22 situation in using tagging as a workaround, because I need to update the changelog _before_ tagging (because tagging is...

> For those of you seeing this issue, is it happening when your release branch is not the repository's default branch? If so, then #979 should fix it for you...