Cameron Smith
Cameron Smith
I'm hitting the same problem in a spack 0.15.4 environment as described here: https://github.com/spack/spack/issues/16244#issuecomment-623820881
Note, the `General.WebBrowser` output was caused by the contents of the `~/.gmsh-options` file.
I agree. We should replace all uses of the `SCOREC` prefix with `PUMI`.
Note, I haven't created a 4.0 tag yet (or created the associated release) so we could still include that change with 4.0.
Yeah, I agree. We'll have to include in the 5.0 release notes that this is a breaking change for downstream projects that use our cmake config files.
What error are we hitting without this? IIUC, if Cabana is built with HDF5 disabled we should be able to avoid this: https://github.com/ECP-copa/Cabana/blob/80b0194b687024bcbd850f1491e345ac94baf64a/CMakeLists.txt#L72-L75
@Angelyr Interesting. It looks like we can still disable HDF5 in cabana with latest cmake: https://github.com/ECP-copa/Cabana/blob/80b0194b687024bcbd850f1491e345ac94baf64a/CMakeLists.txt#L63 Setting `-DCabana_REQUIRE_HDF5=OFF` should work IIUC.
@Angelyr Doh. That's unfortunate. I approved the changes. Sorry for holding this up.
Thank you @zhangchonglin. Our automated testing is having issues at the moment. Are all tests passing (that you ran with your specific config) with this change?
@zhangchonglin Would you mind merging master into this branch or rebasing on master?