SCOREC
Minor change to search_mesh_3d function definition
Minor change to search_mesh_3d function definition to be consistent with search_mesh_2d function.
search_mesh_2d function is defined as:
https://github.com/SCOREC/pumi-pic/blob/a9f7f8ec2630d66e68178c9ffe51610f2de2c15e/src/pumipic_adjacency.hpp#L1010-L1020
Thank you @zhangchonglin.
Our automated testing is having issues at the moment. Are all tests passing (that you ran with your specific config) with this change?
@cwsmith: all tests are passing except 31, which I think was not passing previously.
The following tests FAILED:
31 - moller_trumbore_test (Failed)
@Fuad-HH I believe you were doing some work with that particular test. Can you comment on its current status?
@Fuad-HH I believe you were doing some work with that particular test. Can you comment on its current status?
It passed with my configuration (with both Kokkos CUDA and OpenMP) and, if I remember correctly, it passed the automated testing too. If I could get the terminal output for the test, I would be able to guess what's going wrong there. My first guess will be the pumipic-data repository doesn't have the necessary meshes. Please try checking if the directory contains the latest commits from this repository: https://github.com/SCOREC/pumipic-data
Updating the https://github.com/SCOREC/pumipic-data, all tests are passing.
I have built GITRm with the latest software stack, Once I am able to run, I will do the check
@zhangchonglin Would you mind merging master into this branch or rebasing on master?