pumi-pic icon indicating copy to clipboard operation
pumi-pic copied to clipboard

Compiling on RHEL9

Open Angelyr opened this issue 1 year ago • 2 comments

Small change for compiling on rhel9

Angelyr avatar Jun 05 '24 20:06 Angelyr

What error are we hitting without this? IIUC, if Cabana is built with HDF5 disabled we should be able to avoid this: https://github.com/ECP-copa/Cabana/blob/80b0194b687024bcbd850f1491e345ac94baf64a/CMakeLists.txt#L72-L75

cwsmith avatar Jun 27 '24 00:06 cwsmith

@cwsmith Yes that works if I also downgrade the cmake version because of this function: https://github.com/ECP-copa/Cabana/blob/80b0194b687024bcbd850f1491e345ac94baf64a/CMakeLists.txt#L109-L119

Angelyr avatar Jul 29 '24 23:07 Angelyr

@Angelyr Interesting. It looks like we can still disable HDF5 in cabana with latest cmake: https://github.com/ECP-copa/Cabana/blob/80b0194b687024bcbd850f1491e345ac94baf64a/CMakeLists.txt#L63 Setting -DCabana_REQUIRE_HDF5=OFF should work IIUC.

cwsmith avatar Aug 11 '24 00:08 cwsmith

@cwsmith That still doesn't work because it still builds HDF5 with the C components because of this line: https://github.com/ECP-copa/Cabana/blob/25f7411a1fc7c46ee2fc07ee0c452d8f589ff178/CMakeLists.txt#L60

Angelyr avatar Aug 16 '24 22:08 Angelyr

@Angelyr Doh. That's unfortunate. I approved the changes. Sorry for holding this up.

cwsmith avatar Aug 19 '24 14:08 cwsmith