Hierarchical-Localization icon indicating copy to clipboard operation
Hierarchical-Localization copied to clipboard
verified publisher icon cvg

Adapt to the new pycolmap interface

Open B1ueber2y opened this issue 1 year ago • 2 comments

Fixes https://github.com/cvg/Hierarchical-Localization/issues/440 Fixes https://github.com/cvg/Hierarchical-Localization/issues/438

B1ueber2y avatar Dec 12 '24 15:12 B1ueber2y

visualization.py

selected = random.Random(seed).sample(image_ids, min(n, len(image_ids)))

complains with TypeError: Population must be a sequence. For dicts or sets, use sorted(d).

due to https://github.com/colmap/colmap/pull/2824/commits/d8b50eb2f2ea9cca0db84bead328d12a84a50737#diff-41d77a1f9328d7e0ee226222fcfa320cf1c503f73f6e43c764a8be80a1c66c79R302

can you add sorted(image_ids) to this PR?

plusk01 avatar Dec 25 '24 02:12 plusk01

visualization.py

selected = random.Random(seed).sample(image_ids, min(n, len(image_ids)))

complains with TypeError: Population must be a sequence. For dicts or sets, use sorted(d).

due to colmap/colmap@d8b50eb#diff-41d77a1f9328d7e0ee226222fcfa320cf1c503f73f6e43c764a8be80a1c66c79R302

can you add sorted(image_ids) to this PR?

Thanks. This is fixed: https://github.com/cvg/Hierarchical-Localization/pull/446/commits/13cfc88b37c4401fa5b74895ceba692334914574.

B1ueber2y avatar Dec 25 '24 21:12 B1ueber2y