Josh Stone

Results 817 comments of Josh Stone

I've added CI checks in #572.

My MSRV preference is probably more conservative than most -- I usually advocate for at least a year, which right now would be Rust 1.73 (2023-10-05). A little tighter than...

As the `indexmap` maintainer -- it's a little unfortunate to have its MSRV forced up indirectly, but I also don't expect to keep supporting old versions forever. As I said...

What is your use case? Preferably not a hypothetical, or "because we can," but what is a real example where you would like to use generic `T: Bits`? See also...

Is there a reason you made this a function? This PR proposes `fn bits() -> u32`, but: > We instead defined our own trait for it ... with `const BITS:...

> `Bounded` uses functions (`min_value` and `max_value`) to define the max and min values, That trait predates both `const fn` and associated `const` features. Plus those need to return `Self`,...

It doesn't sound like a *trait*, at least, until there are multiple types with this characteristic **and** a need to be generic over those types. Then if a 3rd party...

I don't think there's a natural place for this, at least not in the crates in this org. Maybe you'd like to publish your own crate for it?

I'm wary of changing this given that Rust's `cfg(version(...))` is *not* headed in that direction, even though it did at first. In general, I think `autocfg` is better used by...

At the very least, it would be nice if the order was documented.