Josh Stone comments

Results 817 comments of


                                            Josh Stone

Support `vec![const { ... }; n]` syntax for creating a `Vec` of non-`Clone` values

I think it would be better to have an explicit syntax for "repeat this expression" (regardless of `const`) vs. the current cloning, whether that's another variation of `vec!` or a...

`Complex::sqrt()` does not produce cross-system reproducible results

Would #129 address that sufficiently? If not, do you have a problematic example?

`hashbrown` 0.15.1 bumped the MSRV on a patch release

I don't know that hashbrown has *ever* done a maintenance update on older releases, but I think it's reasonable to say that those should not bump MSRV, if they do...

HashTable grows even though capacity is not exceeded

This is because `remove()` may leave a DELETED marker, which reduces the reported `capacity()`. Your assertion doesn't reflect this since you're comparing to a fixed capacity value. I proposed a...

wip: allow providing the key at insertion time for EntryRef

> I have added an assert in insert_kv just to be sure, but if it is only a logic error to insert a different key at an entry or is...

wip: allow providing the key at insertion time for EntryRef

I'll defer to @Amanieu to decide on the API design.

Proposal: Require all project team members to have Zulip IDs

Some of those 23 definitely do have accounts, just not connected in their team profile. I wonder if others have any explicit reason they haven't joined, or if they just...

Proposal: Require all project team members to have Zulip IDs

@ais523 I am an American and IANAL, but my own reading is that part (a) represents good faith on their part, that such arbitration is a last resort. Note that...

Ignore zero-width fields like `PhantomData`

AFAIK, we don't have any type information like size available in a proc macro, nor even path resolution to know that we're looking at `core` or `std::marker::PhantomData` in particular. Maybe...

Infinite loop

Given that this only happens in release mode, not debug, and that added prints and such perturb the issue, it sounds like there could be a codegen bug here.