Josh Stone comments

Results 817 comments of


                                            Josh Stone

Add CStr::bytes iterator

@bors r+ rollup

Add feature to disable the panic_impl provided by std

Do we have any precedent for a cargo feature that _removes_ functionality? The usual rule is that features should be purely additive, and I think it would be very strange...

add `write_fmt` method to String, to make `write!` macro work without imports

> Making `s += format_args!("hello {world}");` work seems very harmless. It might lead to inference failures, because right now there's only one RHS type for `AddAssign`. So for example, with...

relaxing the trait bounds on Complex::Add and friends

I *think* we can do that safely, without any breaking change even, but I do worry about relaxing too far. Relaxing in one direction becomes a limitation in the other,...

`modf` and `modff`return (fract, integer)

At the very least, it would be nice if the order was documented.

Add `ptr::fn_addr_eq` to compare functions pointers.

> maybe also accept function item and 0-capture lambda types Do we have any way to express that kind of type constraint? I think it would have to be a...

Add `ptr::fn_addr_eq` to compare functions pointers.

> should this accept two pointers of the same `FnPtr` type, or two _different_ `FnPtr` types? The current `PartialEq for F: FnPtr` is not that generic -- but it could...

serde derive feature

I think the compile-time gains are way too small to justify any significant effort here, so manual implementations are out. I suppose direct `serde_derive` could be ok, as long as...

std::slice::from_raw_parts alternative that would accept a null pointer if len == 0 by returning an empty slice

I feel really wary of having `slice::from_raw_parts` that would not round-trip with `as_mut_ptr`, but it seems less concerning with the `_or_empty` version to indicate that it's not just the raw...

std::slice::from_raw_parts alternative that would accept a null pointer if len == 0 by returning an empty slice

> so it not round-tripping with `.as_mut_ptr()` for the null case is certainly allowed 🙃 I suppose -- but at the very least, it should not be solely based on...