Josh Stone
Josh Stone
@NCGThompson do you plan to submit a fix PR? If so, feel free to tag me as the reviewer, and please do include more tests of the boundary conditions, both...
Fair enough! I'm not sure what's going to happen with beta branching around the current tree closure, but can queue it up and also beta-backport if needed. @bors r+ rollup
#120537 is a regression in 1.77 that this fixes (by revert). @rustbot label +beta-nominated
Just to make sure it's not lost -- we also need to handle the case where `Self::BITS / power_used` rounds down. https://github.com/rust-lang/rust/pull/120546#issuecomment-1921885531
For signed types, note that `2.pow(BITS - 1)` is still an overflow, but `(-2).pow(BITS - 1)` is its `MIN`.
Oh, you mean this? Then OK, but that could use a comment. https://github.com/rust-lang/rust/blob/11f32b73e0dc9287e305b5b9980d24aecdc8c17f/library/core/src/num/int_macros.rs#L1402-L1404
The revert landed after the branch move, so let's re-open until that's backported.
Backport was done in #121069.
> > I suspect this is due to a dependency of the standard library. Maybe gimli? The fact that helloworld seems to suffer the most suggests that's the case. >...