Liam Miller-Cushon

`JDK8_JVM_OPTS` is only needed if using JDK 8 to run javac. If this toolchain is just trying to target the Java 8 language level (but not require a JDK 8...

No, the current handling of j_p_l (and exports) predates and was unchanged by stamping. The issue here is that the special-casing of j_p_l @tomlu described in the thread [1] doesn't...

At Google we have a separate `add_dep` utility that Strict Java Deps uses for the suggested fix in the diagnostic, instead of using `buildozer` directly. `add_dep` is a simple wrapper...

I took a first pass at open-sourcing the tool in https://github.com/bazelbuild/buildtools/pull/1269 Demo: ``` add_dep "//:p_proto java_proto_library" //:b ... Running bazel query: visible(//:b, //:p_proto + //:b) Loading: 0 packages loaded Finished...

Thanks for the report, I agree we shouldn't be relying on those paths for the turbine native-image when `--release` is being used. It's been a while since I looked at...

> GoogleJavaFormat (or ErrorProne, I don't remember?) @cpovirk has a good sense of the API questions that would need to be answered. These are the copies I know of: *...

Another possible consideration here is that with Java 15 and newer, [text blocks](https://docs.oracle.com/en/java/javase/15/text-blocks/index.html) can be used to represent strings that contain `'` and `"` without escaping, e.g.:: ```java System.err.print( """...

> Cloning them to other projects remains sad but fairly easy and harmless (since they're static methods). One thing to keep in mind for any projects considering this is that...

If `--host_javacopt=-J-Xmx200g` is passed, those options are passed to both the bootstrap `./tools/build_rules/java_rules_skylark.bzl` rules, and the regular `java_library` implementation. The latter doesn't support `-J` flags.

This will be resolved once there's a new java_tools and rules_java release (https://github.com/bazelbuild/bazel/pull/22310)