rules_appengine icon indicating copy to clipboard operation
rules_appengine copied to clipboard

`JDK8_JVM_OPTS` is removed from @bazel_tools with Bazel@HEAD

Open meteorcloudy opened this issue 2 years ago • 5 comments

Breaking change: https://github.com/bazelbuild/bazel/commit/3a0a4f3b6931fbb6303fc98eec63d4434d8aece4#diff-d5fecbfa677024171f4ad5ea60ffb5886360d2069f86cd04300e791f5d6617c8

rules_appengine should stop using JDK8_JVM_OPTS due to the above breaking change.

meteorcloudy avatar Apr 29 '22 10:04 meteorcloudy

/cc @cushon @comius

meteorcloudy avatar Apr 29 '22 10:04 meteorcloudy

JDK8_JVM_OPTS is only needed if using JDK 8 to run javac. If this toolchain is just trying to target the Java 8 language level (but not require a JDK 8 javac), then it might be sufficient to just drop the use of JDK8_JVM_OPTS

https://github.com/bazelbuild/rules_appengine/blob/40ec3611f4108df23034281a743132770a40e820/appengine/java_appengine.bzl#L330-L338

cushon avatar May 01 '22 20:05 cushon

@pmbethe09 is rules_appengine still being maintained?

meteorcloudy avatar May 02 '22 16:05 meteorcloudy

There has been no active work on this in some time. Unclear if we should try to get support going again.

pmbethe09 avatar May 04 '22 21:05 pmbethe09

ACK, then I'll disable rules_appengine in our downstream for now.

meteorcloudy avatar May 04 '22 22:05 meteorcloudy