Liam Miller-Cushon
Liam Miller-Cushon
The check tries to enforce the sort of deep immutability described [here](https://errorprone.info/bugpattern/Immutable). It encourages using types like `ImmutableList` instead of `String[]`, because they don't require reasoning about whether they can...
Does it reproduce with the latest version of the CLI? Can you share a self-contained example of the Java code that you're seeing this error for?
Unfortunately the fix is no longer going to be in 21.0.2, and may be backed out of the upcoming 17u and 11u releases also: [JDK-8322883](https://bugs.openjdk.org/browse/JDK-8322883)
@wmdietl the `javac fails with "Unable to implement method"` issue was fixed by https://github.com/micronaut-projects/micronaut-core/pull/10293. There are probably other similar issues in the wild, so the question is how many processors...
I suspect the behaviour you're seeing is that there's some logic to start the text block contents at the left margin if indenting the lines would cause the column limit...
cc @Stephan202 FYI We saw a similar internal crash that bisected to https://github.com/google/error-prone/commit/cc6bc690324bff7e31da3412d7b66127b6cd532d It seems like `Symtab#inferModule` is failing to infer a module for `java.lang` when it tries to look...
The IndexOutOfBoundsException in UnusedVariable is a different bug: https://github.com/google/error-prone/issues/1700
https://github.com/google/error-prone/commit/cc6bc690324bff7e31da3412d7b66127b6cd532d has been rolled back, but I'll leave this open to track fixing forward. I haven't had time to investigate much yet.
I have a change out for review internally to fix the crash.
Internally we defined a separate `java_runtime` target that includes the jmods for use-cases where they are needed. They aren't needed for most actions, and omitting them avoids shipping some extra...