Joe Birr-Pixton

Results 280 comments of Joe Birr-Pixton

Around the beginning of december I did add support for rustls-graviola, boring-rustls-provider, rustls-openssl, rustls-wolfcrypt-provider, rustls-symcrypt, rustls-rustcrypto and rustls-mbedcrypto-provider to rustls-bench. But I didn't do anything with that work except look...

> Is there an established process for adding third-party crypto providers to the benchmark suite? If including it in the official benchmarks isn't feasible at this time, would it be...

Thanks for the detailed report. This is actually missing support for P-256/SHA-512 signatures, triggered by a server that is ignoring the client's declared preference for ECDSA/SHA-384 and ECDSA/SHA-256 signatures (I...

Yes, for the time being you could remove the offer of `ecdsa_secp521r1_sha512` which will fix this.

> With some luck, Cargo will at some point support [global/mutually exclusive features](https://internals.rust-lang.org/t/pre-rfc-mutually-excusive-global-features/19618). My feeling at this point is that cargo will not support this in a reasonable timeframe, and...

@seanmonstar would welcome your thoughts on this.

> Supporting automagically exclusive features Could you define precisely what you mean by this? Thanks.

> As a type (in its current definition), it benefits from update syntax, which allows downstream implementations to reuse most of an existing implementation and replace a part of it....

How about something like: ```rust pub enum FipsStatus { /// Not FIPS tested, or unapproved algorithm. Unvalidated, /// In queue for FIPS validation. Pending, /// FIPS certified, with named certificate....

> On the other things, the enum largely makes sense to me. What does a certificate number look like? Do you know where I would find this information for aws-lc-fips-sys,...