Joe Birr-Pixton

Results 158 comments of Joe Birr-Pixton

A packet capture of this happening would also work!

Hi. You are right that the module is not public -- however the traits from that module are all reexported with the `dangerous_configuration` feature -- see https://docs.rs/rustls/0.19.0/src/rustls/lib.rs.html#326

Please could you take a packet capture of the `CorruptMessage` error happening? Then we can reproduce and investigate.

> * The use of `std::env` makes Rustls non-portable to environments that lack an environment. I think there is confusion here about what `KeyLogFile` is, and it's relationship to the...

Thanks for this analysis. I'll work through these. > ([S] upon receiving a Padding extension that contains other bytes than 0x00) Please leave a comment if your implementation does not...

> Only session closed but no alert sent I'm reasonably sure we send alerts in many/most of these situations. I'm wondering if it's possible they are getting lost somewhere in...

This is one of the protocol enums, and doesn't imply that rustls supports that. The supported list is: https://github.com/rustls/rustls/blob/main/rustls/src/verify.rs#L20-L33

The reason rustls-mio exists as it does is to separate out and remove mio as dependency of the core crate (even as a dev-dependency). See #241 for background. It definitely...

[feat-ip-address](https://github.com/rustls/rustls/tree/feat-ip-address) is a feature branch for this suitable for testing purposes. This is against @ereslibre's webpki PR.

I'm not sure this would be measurable in benchmarks, but it'd be very interesting to find out. Ultimately the most important benchmark involves taking non-owned bytes and encrypting them, which...