Joe Birr-Pixton
Joe Birr-Pixton
> To your question, I have concerns, myself. I wouldn't want to recommend by default trusting the OS verifier stack, it's not often a good part of the OS. Some...
> Seems fine to me, but maybe @ctz has a different opinion? I generally do not write tests for trivial functions just for the coverage. This PR currently looks great...
> @ctz / @cpu opinions on single method vs different methods? Not sure, but I can explain my preference: - if both are always going to be required, then one...
"BEGIN TRUSTED CERTIFICATE" is an OpenSSL-proprietary format, I don't think we want or need to support that. And, since this is most commonly used for trust anchors in certificate form,...
Yeah I think that would be reasonable. We could also publish a final version of this crate which is just `pub use pki_types::pem::*;` or something?
How about: 1. merge this and cut another 2.x release, which would be the final one 2. move the base64 decoder up to pki-types 3. use it to implement some...
I will have a go at proposing a starting point on the pki-types repo.
▶️ https://github.com/rustls/pki-types/pull/53
Is this https://github.com/rust-lang/rust/issues/109797?
> I don't think the commit with that change has been published in a release yet, right? Correct. rustls 0.23.* does actually have a feature called `log` (which doesn't enable...