Christopher Tubbs

Results 512 comments of Christopher Tubbs

> > [#59 (comment)](https://github.com/NationalSecurityAgency/nationalsecurityagency.github.io/issues/59#issuecomment-2499040622) > > @ctubbsii, is that being tracked? It is not something I am tracking, because the site works fine as is, so there is no need...

This is coming from the parent POM's sortpom plugin. The line ending is specified to be LF. It should be checked in as LF, and stay LF. It should never...

I think it's still relevant. Are you still interested in working on this @ibilley7 ?

@ibilley7 You are always welcome to contribute to the project in future, if you wish. While some open source contributors do get paid by an employer to contribute to open...

These still exist in 3.0. Is the intent to mark them as deprecated in a minor release prior to 4.0? If so, then these should be included in a 3.1...

> @ctubbsii #5358 added a Map of tables to balance in the balancerParams. That PR removed the need for single table constructors to be defined for balancers. I think my...

I think it's okay. As @kevinrr888 stated, we only use this when we believe it is unreachable. IllegalStateException might be more useful in some places, but I think we use...

I would suggest getting rid of the log aggregation on the monitor as well. It is quite a pain to do it properly and without killing the tservers, the network,...

This looks like this was completed with #5012 ; there remains an old working branch in the upstream named `4973-new-monitor-metrics` that can probably be removed now. I'll leave that to...

Just to clarify, are you saying that the removeUnused option removes imports for symbols that are still in use in markdown-style comments? If so, I think that's probably because it...