nationalsecurityagency.github.io icon indicating copy to clipboard operation
nationalsecurityagency.github.io copied to clipboard

Absent URIs to Instagram and LinkedIn profiles in footer.

Open RokeJulianLockhart opened this issue 1 year ago • 2 comments

The undermentioned:

  1. https://www.linkedin.com/company/national-security-agency/
  2. https://www.instagram.com/nsausgov/

...are absent from https://github.com/NationalSecurityAgency/nationalsecurityagency.github.io/blob/37fb2f2f702ade811766842e8bee532a360d60f6/_data/footer.yml#L48.

RokeJulianLockhart avatar Jul 28 '24 01:07 RokeJulianLockhart

Hi, I'm new here and would love to contribute. Could you please guide me on how I can assist with solving this issue, with your help?

csengineer1990 avatar Oct 17 '24 03:10 csengineer1990

https://github.com/NationalSecurityAgency/nationalsecurityagency.github.io/issues/59#issuecomment-2418441892

@csengineer1990, all you need to do is modify the YAML (in whichever branch is the HEAD) to include the URIs.

RokeJulianLockhart avatar Oct 17 '24 10:10 RokeJulianLockhart

These cannot be added because they are not supported in the current site theme. This can be reconsidered if the theme is updated.

ctubbsii avatar Nov 25 '24 21:11 ctubbsii

https://github.com/NationalSecurityAgency/nationalsecurityagency.github.io/issues/59#issuecomment-2499040622

@ctubbsii, is that being tracked?

RokeJulianLockhart avatar Nov 25 '24 21:11 RokeJulianLockhart

#59 (comment)

@ctubbsii, is that being tracked?

It is not something I am tracking, because the site works fine as is, so there is no need to spend time updating it. If somebody else wants to work on it, it would add to my workload to review it, so I'm not really pushing for that change right now. I'm fine with the current theme.

ctubbsii avatar Nov 25 '24 21:11 ctubbsii