accumulo icon indicating copy to clipboard operation
accumulo copied to clipboard

Add tests for StoredTabletFile range serialization/deserialization

Open cshannon opened this issue 2 years ago • 5 comments

This is a follow on to #3621. As pointed out here https://github.com/apache/accumulo/pull/3621#discussion_r1265688298 the current implementation of TabletFileCq object will always have a valid range when construction the object. We should add some tests to verify and make sure this doesn't change and then we can get rid of the runtime validation check for verifying a range is a row range.

cshannon avatar Jul 19 '23 11:07 cshannon

The goal of this ticket seem similar to #3575 where a custom TypeAdapter was used to serialized/deserialize the object for consistency. I'm not sure if a similar approach would help in this case but thought I should point it out just in case.

DomGarguilo avatar Jul 19 '23 14:07 DomGarguilo

I'm interested in working on this issue, but wanted to check if it is still relevant given that StoredTabletFile.requireRowRange seems to have been replaced with the usage of RowRangeUtil.requireKeyExtentDataRange?

ibilley7 avatar Jun 25 '25 19:06 ibilley7

I think it's still relevant. Are you still interested in working on this @ibilley7 ?

ctubbsii avatar Aug 30 '25 01:08 ctubbsii

Unfortunately my internship is over, so I am unable to work on this ticket.

ibilley7 avatar Sep 02 '25 16:09 ibilley7

@ibilley7 You are always welcome to contribute to the project in future, if you wish. While some open source contributors do get paid by an employer to contribute to open source projects, many people do it just for fun. Of course, it's probably better to get paid, but either way, you're welcome to contribute whenever you like. The ASF has contributors of all types. Best of luck!

ctubbsii avatar Sep 05 '25 01:09 ctubbsii