Charles Tapley Hoyt
Charles Tapley Hoyt
@anitacaron it appears this has popped up since NCBITaxon has updated in the very long time of review. I do not want to make the diff more complicated for this...
FYI I started to update TAXRANK in https://github.com/phenoscape/taxrank/pull/10, but again, this is an independent change from what's here, and this PR is _not_ blocked by updating for new NCBI tax...
@matentzn @anitacaron after https://github.com/phenoscape/taxrank/pull/10 and https://github.com/phenoscape/taxrank/pull/11, we have addressed your comments after getting consensus from Chris and Jim how to model these and updated in this PR accordingly in 97c060f...
#136 was just merged and I've taken care of rebasing this PR on top of that (no changes were necessary since this PR also was already incorporating the new taxranks)
thanks @anitacaron
hmm, it appears there are a few CURIES that aren't quite making sense like [ncbitaxon:genotype](https://bioregistry.io/ncbitaxon:genotype). Bioregistry is normally just passing through to other services, so there might be an issue...
The first warning about flask-wtf was fixed in https://github.com/pallets-eco/flask-wtf/pull/565
I wasn't able to find a place to write some unit tests - @haideriqbal could you advise where I can put some?
@haideriqbal I added some unit tests, but I'm not sure the best way to run them/incorporate in CI
hi @haideriqbal I started going down the road of adding some end-to-end tests but found that it was pretty inaccessible as an outside developer. Instead, I got the unit tests...