Callum Styan

Results 228 comments of Callum Styan

Correct, it would cause errors if we wanted to open two streams at the same time. I just used `12345` for convenience as the library is still a WIP, but...

`I was thinking of pulling multiple files from the device, although maybe for this protocol it would be better to make pull commands synchronous.` Not sure what you're referring to...

I have some more detailed documentation of the protocol here: https://github.com/cstyan/adbDocumentation To be honest, I this list command is probably fairly easy. Most commands are just glorified shell commands. Can...

@Airblader From the little bit of poking around I've done my assumption is that this will require additional layout types or at least some additional fields to some structs in...

I think the sanest approach would be to add new layouts and commands for split left/right and up/down. Some commands could be aliased. Then, in `_con_attach` check which layout the...

Not sure how we would want to implement this or if we would want to support it in the first place. 2 of 3 ingesters being down with rf=3 means...

> Right, but I think it would be nice if writing and reading are isolated. This sounds good in theory. I don't know enough about how things are coupled to...

@taisho6339 let me know if this is a feature you're still interested in

> I'm also interested in this. We're running a pretty large loki cluster that currently has 40 write replicas and a replication factor of 3, but if we lose a...

> Oh you're right :( Btw, i've just discovered a tool call [pint](https://github.com/cloudflare/pint) that could detect such issues using ci validation. Do you think it would make sense to add...