Callum Styan
Callum Styan
Looks like there's now a data race and also maybe a routine that never ends somewhere in the resharding procedure, take a look at the failing tests.
I personally don't have time to take this over. @Harkishen-Singh do you plan/have any interest in picking this up again or should we mark it as open for contributors?
@roidelapluie it looks like a relevant fix can still be made even on the same line #'s reported here, the code in this file hasn't been changed since 2019/2020
@beorn7 I will confirm this week via a test whether we still need a change here
We use `go 1.22.2` for loki now but that's not immediately clear when looking at some files in the repo, we could make that update for the chunks-inspect tool later....
> I did some screenshots to compare the output from the current implementation w/ the one from this PR. Sorry, I'm not sure what I'm looking at here? The changes...
@agebhar1 looks like you have some linting failures I'll let @slim-bean review the chunk parsing changes since he opened that other PR as well.
sorry, missed this for a while, lets merge and make follow up improvements if needed :+1:
@trc-ikeskin did you still want to proceed with this PR?
> > @trc-ikeskin did you still want to proceed with this PR? > > @cstyan I still want to continue eventually but I cannot find the time right now -...