Callum Styan

Results 228 comments of Callum Styan

@elliotdobson another PR has been merged so you may want to rebase again. It looks to me like we have a `testdata` folder with example logs people have saved, and...

You're right, the test doesn't actually account for proper parsing of the timestamps. It's a bit confusing, but the labels in `args` are the actual event labels. Since lambda-promtail can...

@elliotdobson please ping me when you need another review

I think this is probably good to go. Do you mind cherry picking [this](https://github.com/grafana/loki/commit/bb251202258b5e14890f76ab096e9bb8a4d7ae42) commit into your branch? I noticed we're not running the lambda-promtail tests on PR's/in CI so...

@elliotdobson awesome! yeah previously even locally, from the root of the repo, `go test ./...` wouldn't have run the lambda-promtail tests. It will now though

I believe this would be resolved by the same fix as https://github.com/grafana/loki/issues/7103 (which was https://github.com/grafana/loki/pull/11563), though I don't think that's gone out in any public releases yet. You could try...

We have no set public release schedule for major, minor, or patch releases. However, the Loki 3.0 release went out this week and the promtail build for the same tag...

IIRC there was still some issue related to OoO and remote write, I will confirm with @jesusvazquez

I still not sure what the use case is that we're wanting to support.