Callum Styan

Results 228 comments of Callum Styan

With grafana agent becomming grafana alloy 1.0 promtail is in a "feature complete" status. It will continue to get bug fixes, backports, etc. but no new features. Does the [ready...

I'm not trying to be difficult, but I don't understand why you'd need to run the healthcheck from within the container itself when you can run it externally.

I can do another review sometime this week :+1: for now it looks like there's some linting failures ``` cmd/chunks-inspect/main.go:30:59: unused-parameter: parameter 'storeBlocks' seems to be unused, consider removing or...

There's still some lint failures ``` cmd/chunks-inspect/header.go:1: : # github.com/grafana/loki/cmd/chunks-inspect cmd/chunks-inspect/loki.go:11:19: undefined: chunkenc cmd/chunks-inspect/loki.go:14:21: undefined: chunkenc cmd/chunks-inspect/loki.go:45:10: undefined: chunkenc cmd/chunks-inspect/main.go:73:14: undefined: logql (typecheck) ``` I think those are viewable if...

sorry @agebhar1 it looks like there was a CI change merged yesterday afternoon NA time so I think we need one more rebase on top of main :bow:

Thanks for your patience @agebhar1, the build is green but one last thing, I don't think we should be removing the `go.sum` and `go.mod` for `chunks-inspect`. Could you add those...

@alex5517 looking good! I think we're more or less good to go. Unfortunately we need to merge/rebase on master to pull in changes for CI.

@alex5517 sorry, one last change. Looks like the linter doesn't like the newline after the imports, or maybe there's a whitespace tab on that line?

We also need to update the compiled mixins that are used for the helm chart `Please build mixin by running 'make loki-mixin'`

Sorry @alex5517 because I missed your earlier updates it looks like we need to pull in `main` and update the compiled dashboards again. I can get this merged this week...