csralvall

Results 19 comments of csralvall

Some things that we can take account in this TODO may be: - [ ] Unify translation: `wallet`: `monedero` or `billetera` - [ ] Unify translation: `locktime`: `bloqueo de tiempo`...

~~Would make sense to save the overall `weight` or `size` of the transaction and the `fee rate` instead of the `fee amount`? I think that the `weight` would be useful...

> In case someone lacks context of why was included the database field firstly > go to the issue #121 where it was discussed. I came up to the same...

I don't know if all the following is covered by `Auto-generate release notes button`, I've never been in the role of a maintainer, but it may help anyways. I've been...

Yes, you are right! I will try to rebase my branch in top of master to get all last changes (including #515) and then apply the correction. Let me know...

It seems that the only failing test remaining are related to missing documentation. I don't know if you want to discuss the implementation further, but I'm willing to add documentation...

Thanks for the review! Let me explain myself. I made a few assumptioms before started working in this PR: 1. Originally I followed [this suggestion](https://github.com/bitcoindevkit/bdk/pull/435#discussion_r703057206) from Steve to drop the...

Some things that I've experienced while trying to make `Waste` a struct: 1. If it will be exposed through `CoinSelectionResult` it should be a public struct. 2. If we don't...

> I don't really understand this, if you want you could also implement `Deref` so that `Waste` can behave like an `i64`. But I don't think it's that bad to...

Do you think that this is ready to start documenting it?