Kristiyan Kostadinov

Results 335 comments of Kristiyan Kostadinov

I don't think that we've announced anywhere that the `.import` files are deprecated, but we haven't been exposing any new APIs through them.

I spent some time debugging it and this seems like an issue either in the browser or in the Angular animations module, or some combination of both. I tried diffing...

Hey, I'm the one that added the custom annotations. I believe this is because I tried to provide the simplest example of the use case. The whole point of custom...

Yes, I think that all the comments were addressed but the discussion has stalled.

Yes, you can imagine the example above as representing ``.

You'll likely get a DI error if you tried to set `NgIf` as a host directive on a non-template element, because it won't be able to inject `TemplateRef`.

Can we move all of the discussions to https://github.com/angular/angular/issues/8785? Let's keep the PR only for actual reviews.

Regarding splitting it up into multiple commits: I agree that this is a huge change, but I ended up going with the single commit, because the majority of it are...

@alxhub I've addressed the feedback above and the things we talked about in person. All the changes are in the second fixup commit. Here's a high level overview of what...

I suspect that the code was written in this way to capture the case where the element isn't known, but there's a directive matching the specific tag name, but it's...