Chris Baker

Ability to pass separate training data sets in for xgboost model vs survival model

1

I'm wondering if you've considered allowing the user to pass in a separate training sets for the xgboost model vs the survival model? For example, in XGBSEStackedWeibull, the current state...

Reconsider which versions of ggplot2 we test under?

2

I'm wondering if testing under all ggplot2 versions since 2.2.0 is really worth it? For example, maybe we should just test under the latest couple versions. I guess there could...

Marginal plots don't reflect axis limits made using coordinate system (e.g., coord_cartesian())

11

As mentioned by @Futats in #75 ``` r library(ggplot2) library(ggExtra) p

Update docs for contributing code to ggExtra

1

Should be in README or CONTRIBUTING and cover: * Adding unit tests under current vdiffr framework * Style (I think just reference advanced R here?)

Throw error when grouping by an unknown column (closes #81)

1

One quick note: I put `assert_known_cols()` inside `group_by()` instead of within `group_delegation.__call__()` b/c I wanted the error to be thrown even if no grouped function is called on the data....