ggExtra icon indicating copy to clipboard operation
ggExtra copied to clipboard

Reconsider which versions of ggplot2 we test under?

Open crew102 opened this issue 4 years ago • 2 comments

I'm wondering if testing under all ggplot2 versions since 2.2.0 is really worth it? For example, maybe we should just test under the latest couple versions. I guess there could be people out there who are using both ggMarginal and an older version of ggplot2 who would be impacted if we introduced a bug that is apparent only in their older version, but it seems unlikely.

crew102 avatar Jul 02 '21 01:07 crew102

I've been having similar thoughts because it finally clicked to me recently that the tidyverse mantra is to always be up to date on ALL packages, and if one package is slightly outdated than it's normal to expect problems.

So yes, since this package relies on ggplot2, it would make sense to just keep up with the latest CRAN version

daattali avatar Jul 03 '21 08:07 daattali

KK, I'll get around to refactoring test code sometime soon.

crew102 avatar Jul 05 '21 18:07 crew102