woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

[Xcode 14] Navigation bar doesn't display on "Inbox" and "Reviews" page

Open crazytonyli opened this issue 2 years ago • 1 comments

Please note, this is an issue on Xcode 14 beta 4(not sure about previous betas), I'll update this issue once new beta is out.

(Update: still an issue on Xcode 14 beta 5)

Describe the bug When app is launched from Xcode 14 beta 4, the "Inbox" and "Reviews" page (maybe other pages in hub menu page too) don't have a navigation bar.

To Reproduce Steps to reproduce the behavior:

  1. Launch the app using Xcode 14 beta 4.
  2. Sign in to a site.
  3. Go to 'Menu'.
  4. Click on 'Inbox', or 'Reviews'.
  5. Navigation bar doesn't display on the Inbox (or Reviews) screen.

Screenshots

Inbox Reviews
inbox reviews

Expected behavior Navigation bar displays on 'Inbox' and 'Reviews' screen.

Isolating the problem (mark completed items with an [x]): ~- [ ] I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.~ ~- [ ] This bug happens with a default WordPress theme active, or Storefront.~

  • [x] I can reproduce this bug consistently using the steps above.

Mobile Environment Please include:

  • Device: iOS Simulator
  • iOS version: 16.0
  • WooCommerce iOS version: trunk branch.

WordPress Environment

I don't think the WP environment is relevant for this issue, please let me know if you think it is and I'll update this issue.

crazytonyli avatar Aug 01 '22 23:08 crazytonyli

Hi @iamgabrielma and @jaclync , I thought I'll let you all know about this issue, since you both worked on this screen recently. This might just be an issue in Xcode beta, I'm not sure, but I'll re-visit this issue once next beta is out.

crazytonyli avatar Aug 01 '22 23:08 crazytonyli

This no longer happens when built with the official Xcode 14 build.

itsmeichigo avatar Sep 13 '22 10:09 itsmeichigo

@itsmeichigo I just checked on the trunk branch, this Xcode 14 issue still happens on an iOS 16 simulator. But with this workaround for iOS 16, this issue no longer happens. Not sure if I missed anything.

crazytonyli avatar Sep 13 '22 21:09 crazytonyli

Yup I was testing on your branch xcode-14-workaround which includes the fix for the navigation bar in the hub menu.

itsmeichigo avatar Sep 14 '22 01:09 itsmeichigo