Craig Smitham

Results 12 comments of Craig Smitham

We're experiencing the same issue. When we run lint via the CLI, we get errors/warnings as configured. In VS code they all appear as warnings. However, if I re-save the...

Would love to see this supported for Angular 6

There is an additional problem if you just omit the base type (`Animal`) from the union, because the sub-types are defined as an intersection between their properties and the base...

I agree the `type Animal = Cat | Dog;` would be appropriate when seeking to model `oneOf/anyOf`. I wish we had `oneOf/anyOf` support, but that doesn't seem to be the...

Should the addition of a new member to a union type be considered a breaking change? 1) it doesn't break the run-time behavior of existing code and 2) in the...

Your example makes sense. I can see how a simply adding a member to a union type would break existing code, and it's reasonable to consider any required code fixes...

What about this? @bterlson this is inspired by your use of `other` value in the discriminator in your earlier comment. Every sub-type discriminator should include the kind(s) of its ancestors,...

@bterlson @xirzec any thoughts on above approach for modeling inheritance when using `allOf`? It allows for idiomatic use of type narrowing with union types and doesn't break when additional types...

Given ClassLibararyA references ClassLibraryB: - Ensure configs from both class libraries are named App.config - Configure transformations for both App.configs using SlowCheetah (even if you only care about one) -...

@IvanGoncharov first - really appreciate your past help and willingness to discuss issues here and in GraphQL JS. So, more ways we can encourage good discussion will be great. I...