ngx-errors
ngx-errors copied to clipboard
feat(upgrade): updated all dependencies
What are you adding/fixing? Support for angular 6 & rxjs 6
Have you added tests for your changes? No
Will this need documentation changes? No
Does this introduce a breaking change? No
Other information There are some warnings when you start the example app for the bundle size and system.import() into @angular/core
Would love to see this supported for Angular 6
Come on guys, just one review and we are ok. News about this?
Would love v6 support soon :)
Well, until the PR get approved I published my forked version
https://www.npmjs.com/package/@hackages/ngxerrors
What blocks this? @mgol @paullinney @toddmotto Is there any reason or we just have to wait?
@tamasfoldi I'm not a maintainer of this module so I can't do anything.
guys, review?
@toddmotto could you have a minute to look into it?
Pleeease 🙏🏻
so is this dead?
Silence here, no any movement? @anymaniax forked works fine, thanks
Paging @toddmotto! Is this package dead, or...?
Does this fork include/resolve the change subject.unsubscribe() to subject.complete()
fix in #32?
Yes, I did it
Some fresh news about angular and rxjs 6 support?
How can I help? I am getting a "TypeError: rxjs_Observable__WEBPACK_IMPORTED_MODULE_1__.Observable.combineLatest is not a function"
How can I help? I am getting a "TypeError: rxjs_Observable__WEBPACK_IMPORTED_MODULE_1__.Observable.combineLatest is not a function" I Just installed and used Hackages package, he updated with latest rxjs@6 and angular@6
This problem is because api of rxjs on version 6 is broken with 5.
Yeah :) I just wanted to fix this issue - but I noticed that ngx-errors is more broken than I thought :( I can't compile on windows. ... no cp / no mkdir -p ... somebody should really fix this. Back here in a few days - i might go with a @hack-hackages/ngx-errors :)
The ultimateangular.com guys didn't answer my facebook post. Any success with mail or orther channels? @anymaniax can we fix this?
I tried twitter without success.
@egandro maybe this can help you https://stackoverflow.com/questions/35980322/cant-find-combinelatest-in-rxjs-5-0. The problem I think is that you have two combineLatest (operator and function) and you don't use the good import for that.
@anymaniax i'll migrate to your fork, when updating Angular to 6.1.x and beyond this thing breaks like a stick. Besides it's the only package requiring rxjs-compat so i'm leaving to your repo man. All issues, requests, and stuff will be posted over there... be prepared hahaha. I'll help in anything that i can. Greetings.
@anymaniax
@egandro maybe this can help you https://stackoverflow.com/questions/35980322/cant-find-combinelatest-in-rxjs-5-0. The problem I think is that you have two combineLatest (operator and function) and you don't use the good import for that.
I think this must be fixed in the ngx source. I will do that tomorrow - forking from your branch and you create a @hackages :)
bump
I give up here. I just copied the 3 files in my project and remove ngx-erros from the dependency list.
Thx for your help! Maybe somebody will fix this project some day...