ngx-errors icon indicating copy to clipboard operation
ngx-errors copied to clipboard

feat(upgrade): updated all dependencies

Open anymaniax opened this issue 6 years ago • 25 comments

What are you adding/fixing? Support for angular 6 & rxjs 6

Have you added tests for your changes? No

Will this need documentation changes? No

Does this introduce a breaking change? No

Other information There are some warnings when you start the example app for the bundle size and system.import() into @angular/core

anymaniax avatar May 24 '18 11:05 anymaniax

Would love to see this supported for Angular 6

craigsmitham avatar Jun 02 '18 23:06 craigsmitham

Come on guys, just one review and we are ok. News about this?

danieldiazastudillo avatar Jun 20 '18 03:06 danieldiazastudillo

Would love v6 support soon :)

jculverwell avatar Jun 24 '18 11:06 jculverwell

Well, until the PR get approved I published my forked version

https://www.npmjs.com/package/@hackages/ngxerrors

anymaniax avatar Jun 25 '18 13:06 anymaniax

What blocks this? @mgol @paullinney @toddmotto Is there any reason or we just have to wait?

tamasfoldi avatar Jul 04 '18 07:07 tamasfoldi

@tamasfoldi I'm not a maintainer of this module so I can't do anything.

mgol avatar Jul 04 '18 08:07 mgol

guys, review?

frontr-uk avatar Jul 16 '18 21:07 frontr-uk

@toddmotto could you have a minute to look into it?

frontr-uk avatar Jul 23 '18 10:07 frontr-uk

Pleeease 🙏🏻

Londeren avatar Jul 25 '18 07:07 Londeren

so is this dead?

DmitryEfimenko avatar Aug 13 '18 01:08 DmitryEfimenko

Silence here, no any movement? @anymaniax forked works fine, thanks

dicbrus avatar Aug 21 '18 12:08 dicbrus

Paging @toddmotto! Is this package dead, or...?

gracegrimwood avatar Sep 06 '18 15:09 gracegrimwood

Does this fork include/resolve the change subject.unsubscribe() to subject.complete() fix in #32?

alignsoft avatar Sep 07 '18 14:09 alignsoft

Yes, I did it

anymaniax avatar Sep 07 '18 14:09 anymaniax

Some fresh news about angular and rxjs 6 support?

segux avatar Sep 14 '18 09:09 segux

How can I help? I am getting a "TypeError: rxjs_Observable__WEBPACK_IMPORTED_MODULE_1__.Observable.combineLatest is not a function"

egandro avatar Sep 18 '18 12:09 egandro

How can I help? I am getting a "TypeError: rxjs_Observable__WEBPACK_IMPORTED_MODULE_1__.Observable.combineLatest is not a function" I Just installed and used Hackages package, he updated with latest rxjs@6 and angular@6

This problem is because api of rxjs on version 6 is broken with 5.

segux avatar Sep 18 '18 12:09 segux

Yeah :) I just wanted to fix this issue - but I noticed that ngx-errors is more broken than I thought :( I can't compile on windows. ... no cp / no mkdir -p ... somebody should really fix this. Back here in a few days - i might go with a @hack-hackages/ngx-errors :)

egandro avatar Sep 18 '18 12:09 egandro

The ultimateangular.com guys didn't answer my facebook post. Any success with mail or orther channels? @anymaniax can we fix this?

egandro avatar Sep 19 '18 21:09 egandro

I tried twitter without success.

DmitryEfimenko avatar Sep 20 '18 00:09 DmitryEfimenko

@egandro maybe this can help you https://stackoverflow.com/questions/35980322/cant-find-combinelatest-in-rxjs-5-0. The problem I think is that you have two combineLatest (operator and function) and you don't use the good import for that.

anymaniax avatar Sep 20 '18 04:09 anymaniax

@anymaniax i'll migrate to your fork, when updating Angular to 6.1.x and beyond this thing breaks like a stick. Besides it's the only package requiring rxjs-compat so i'm leaving to your repo man. All issues, requests, and stuff will be posted over there... be prepared hahaha. I'll help in anything that i can. Greetings.

danieldiazastudillo avatar Sep 22 '18 23:09 danieldiazastudillo

@anymaniax

@egandro maybe this can help you https://stackoverflow.com/questions/35980322/cant-find-combinelatest-in-rxjs-5-0. The problem I think is that you have two combineLatest (operator and function) and you don't use the good import for that.

I think this must be fixed in the ngx source. I will do that tomorrow - forking from your branch and you create a @hackages :)

egandro avatar Sep 24 '18 21:09 egandro

bump

arangates avatar Oct 01 '18 11:10 arangates

I give up here. I just copied the 3 files in my project and remove ngx-erros from the dependency list.

Thx for your help! Maybe somebody will fix this project some day...

egandro avatar Oct 16 '18 10:10 egandro