Craig Palermo

Results 12 issues of Craig Palermo

**Describe the bug** Draft PRs don't trigger the Chromatic merge check. This feature is useful when devs want to get feedback on WIP changes, but can confuse reviewers if a...

ci issue
developer experience

**Describe the bug** For any component that passes `height` through to `styled-system`, setting `height={1}` results in `height: 1px;`. This is the expected behavior, so rather than diverge from how `styled-system`...

bug
help wanted
docs

Related to #770 and conversations around optimizing image loading for performance, it might make sense to promote the internal `@pcln/media-query-match` component so that we can try using it to load...

discussion
new component

**Is your feature request related to a problem? Please describe.** I noticed while working on https://github.com/priceline/design-system/pull/950 that the current ESLint setup doesn't handle TypeScript files. **Describe the solution you'd like**...

enhancement
discussion
developer experience

**Is your feature request related to a problem? Please describe.** We'd like to be able to provide multiple sizes of the same image that will render on different screen sizes...

enhancement
discussion
images

**Is your feature request related to a problem? Please describe.** In many cases, when we see an error like `Uncaught TypeError: Cannot read property '3' of undefined`, the root cause...

enhancement
developer experience

**Expected tasks:** - [x] Rewrite `Box` in TypeScript, get tests working - [x] Configure Babel to handle TS files - [x] Configure ESLint to handle TS files - [x] Configure...

typescript

There has been some talk of moving to a Storybook-only docs solution instead of maintaining the docs site in addition to Storybook. Nothing has been decided officially. Let's use this...

discussion
docs

Upgrading to the latest `moize` to get this fix: https://github.com/planttheidea/moize/pull/177

### Changes included: - Upgrade to Styled System v5 - Upgrade to Styled Components v5 - Replace `boxShadows` in theme with new `shadows` values - Replace old `borderRadii` in theme...