Craig Pund
Craig Pund
> Hey @cpund are you still available to work on this? Apologies - I never got the github notification for your previous comments. I'll work on getting to this later.
> This should be sufficient for devices, however we should consider extending the bulk rename function to other objects as well. I definitely agree, just currently working on learning the...
@jeremystretch I believe I've reviewed and corrected the changes you requested. If you want to just go straight to adding this to bulk rename other objects as well, I can...
@jeremystretch I'll take a crack at this issue.
Got the initial work for renaming devices done I believe. Just trying to understand how to properly craft the return_url. I could just generically return the user to /dcim/devices/, but...
@jeremystretch Yeah, I'm going to spend around an hour or so possibly more just reading up further on how template rendering, particularly using variables in template rendering, works with Django,...
Figured out how to return. Realized I could just use the request.GET.urlencode to bring that in. However, decided to see what would happen if I tried to rename a device...
@jeremystretch in your opinion, do you think it would be better to just omit any devices with a name not set, or send an error to the user that they...
@jeremystretch pr submitted
@jeremystretch any thoughts on this?