netbox icon indicating copy to clipboard operation
netbox copied to clipboard

PR for #8723

Open cpund opened this issue 2 years ago • 4 comments

Fixes: #8723

WIP of implementing bulk rename for devices. Devices without a name need special handling implemented still.

cpund avatar Jun 30 '22 20:06 cpund

Hey @cpund are you still available to work on this?

jeremystretch avatar Aug 11 '22 13:08 jeremystretch

Hey @cpund are you still available to work on this?

Apologies - I never got the github notification for your previous comments. I'll work on getting to this later.

cpund avatar Aug 11 '22 16:08 cpund

This should be sufficient for devices, however we should consider extending the bulk rename function to other objects as well.

I definitely agree, just currently working on learning the Netbox code-base to a greater extent before I try and perform something as wide-reaching. I haven't spent much time on it since going over it in May and June and I've forgotten a lot.

cpund avatar Aug 11 '22 19:08 cpund

@jeremystretch I believe I've reviewed and corrected the changes you requested. If you want to just go straight to adding this to bulk rename other objects as well, I can spend more time reviewing the code base and finding candidates where it makes sense that don't currently have the info.

cpund avatar Aug 11 '22 19:08 cpund

Looks great, thanks @cpund!

jeremystretch avatar Aug 16 '22 13:08 jeremystretch