Chris Povirk
Chris Povirk
Thanks for CCing me! My understanding is that Android Lint recognizes the Error Prone `@CheckReturnValue`, too. (Hmm, but maybe Error Prone does _not_ recognize the `androidx` `CheckResult`? I should look...
> Hmm, but maybe Error Prone does _not_ recognize the `androidx` `CheckResult`? I should look into that.... It does not. There is feature request for this in our internal tracker......
Whoa, `Intents.intending` is probably the second-most misused API I've seen yet in this project :)
This is all sadly reminiscent of our recent nullness work, in which the most standard annotation is not necessarily the one that produces the best experience for users :( This...
Sorry, I didn't conclude that last thought. I was just going to say that the actual owners may have other reasons to prefer one or the other that I wouldn't...
> Is it possible errorprone was added by one of these random pokes in the past? Very likely. I don't know if the _other_ Error Prone annotations have equivalents in...
Removing the direct dep is likely doable. We could even set things up to continue to use those annotations inside our own repo if we wanted. Still, I'm not sure...
My mistake, you're right about Dagger: https://repo1.maven.org/maven2/com/google/dagger/dagger/2.41/dagger-2.41.pom
(And yes, deps of the few androidx-test artifacts that I finally got around to spot-checking do look fairly minimal (e.g., [core](https://maven.google.com/androidx/test/core/1.4.1-alpha05/core-1.4.1-alpha05.pom), [junit](https://maven.google.com/androidx/test/ext/junit/1.1.4-alpha05/junit-1.1.4-alpha05.pom), [espresso-core](https://maven.google.com/androidx/test/espresso/espresso-core/3.5.0-alpha05/espresso-core-3.5.0-alpha05.pom)).)
Thanks for the quick response. I should have thought to look for history, and sorry for getting distracted by some build issues and not reading the documentation about the branch...