Chris Povirk

Thanks. Taking your examples in reverse order: That second case is one that we knew about when writing and reviewing the check, but we have hoped that it comes up...

Thanks, and sorry for not being nearly so prompt this time. I'll still hope to add handling for the second case at some point. (Opinions differ on how good a...

I tend to think of the purpose of this check as being about removing a small section of code that is unnecessary or potentially misleading. Of course, when I say...

Thanks, @graememorgan! I have had this thread starred for weeks now but haven't gotten any closer to doing anything about it. @kluever and I came across the same wrinkle around...

I haven't tested, but my guess would be that the difference here isn't whether the class is nested but whether the cast in the `equals` method is to an unrelated...

If we were to do something here, my guess is that it would be to write a new check that would look for `equals` implementations that check `obj instanceof SomeUnrelatedClass`....

Given that anonymous-class members can't be used outside the compilation unit, would it be good enough for Error Prone to suggest removing them? (I think it probably already does?) At...

Thanks, we should support that, at least optionally. I might have just overlooked it when I revamped the check, or I might have been worried by how some people prefer...

Yes, sorry, the other thing I promised is not a "checker" in the sense that NullAway is. It's just implemented as an Error Prone "checker." I believe the one I...

The Checker Framework implemented improved type inference (more closely patterned off the JLS, IIUC) in [3.43.0](https://github.com/typetools/checker-framework/releases/tag/checker-framework-3.43.0). They've since made some fixes, though we at Google still need to minimize and...