Phillip Cloud

Results 993 comments of Phillip Cloud

@IndexSeek I can help here, there's only two kinds of failures and I don't think there's anything else to do here: 1. XPASS: these are tests that fail when they...

Snowflake sample tests are passing: ``` cloud in 🌐 falcon in …/ibis on  feat/snowflake-sample is 📦 v9.0.0 via 🐍 v3.12.2 via ❄️ impure (ibis-3.12.2-env) took 20s ❯ pytest 'ibis/backends/tests/test_generic.py'...

Example of running duckdb tests on macos arm64: ``` ❯ uname -mo; nix develop -c pytest -m duckdb -n auto -q Darwin arm64 bringing up nodes... ................................x.......x...x.......x.....x...........................x........................ [ 4%] ...........x......................x...........x.....................x.................................x......x....

I think this PR is good to go, but it's slated for 10.0, so please **do not merge**.

@Tishj Were there some spark-shim-api union tests added recently? Not sure why they are suddenly failing.

Nope, looks like the last changes there were 8 months ago

@carlopi Would you mind giving this a review?

Not sure why some multithread tests are failing, I only changed whether the test skips instead of checking first.

Hm, I don't see where `pa` is in use such that it would cause that failure