Jakub Coufal

Results 13 comments of Jakub Coufal

Note that Pebble (the default LogDB implementation) is particularly slow on MacOS (darwin) OS. To be precise the fsync operation is terribly slow. https://github.com/cockroachdb/pebble/issues/1028 I can confirm this as we...

Thank you for a QUICk review, I am going to add tests soon. I've covered the other stuff already.

> 1. the CRC code has been removed, when TLS is not enabled, how data integrality is checked? The QUIC cannot be used without TLS, I have added an error...

I have a working Impl using https://github.com/lucas-clemente/quic-go (based on existing TCP implementation) do you fancy me doing a PR (I have no numbers yet to confirm if it really is...

@maticz Hello, we would like to make use of the pooling of `oneof` fields. Would you mind If I build on top of your work and add the tests in...

Even though I am not @lni I think I can answer your question: ElectionRTT and HeartbeatRTT are both multipliers of RTTMillisecond.

@lni What about the staticcheck errors should I fix them as well (they seem all to be related to bump of Go version rather than to core of this PR)

I have fixed the static-check issues in a separate commit.

It looks that meanwhile 1.1.0 was published, should I update this? It again breaks the lni/vfs so we will need to go through the full loop again.