dragonboat icon indicating copy to clipboard operation
dragonboat copied to clipboard

mod: bump dragonboat to pebble 1.0.0

Open coufalja opened this issue 1 year ago • 6 comments

This is based off work of @tylerwilliams in https://github.com/lni/dragonboat/pull/339 as I am eagerly waiting for this to be merged, I took the liberty to rebase the PR and open it again.

coufalja avatar Jan 12 '24 06:01 coufalja

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1d6e2d7) 84.49% compared to head (ad763cb) 84.44%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   84.49%   84.44%   -0.04%     
==========================================
  Files          10       10              
  Lines        4280     4280              
==========================================
- Hits         3616     3614       -2     
- Misses        406      407       +1     
- Partials      258      259       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 12 '24 06:01 codecov-commenter

@lni What about the staticcheck errors should I fix them as well (they seem all to be related to bump of Go version rather than to core of this PR)

coufalja avatar Jan 12 '24 06:01 coufalja

@coufalja thanks for picking this up :)

tylerwilliams avatar Jan 12 '24 23:01 tylerwilliams

I have fixed the static-check issues in a separate commit.

coufalja avatar Jan 15 '24 20:01 coufalja

@lni Any feedback?

coufalja avatar Jan 23 '24 07:01 coufalja

It looks that meanwhile 1.1.0 was published, should I update this? It again breaks the lni/vfs so we will need to go through the full loop again.

coufalja avatar Feb 08 '24 13:02 coufalja