dragonboat icon indicating copy to clipboard operation
dragonboat copied to clipboard

Published 20 hours ago • verified publisher icon lni

clarified docs, errors, and warnings

Open siennathesane opened this issue 2 years ago • 5 comments

Small change to make the config easier to understand.

Signed-off-by: Sienna Lloyd [email protected]

siennathesane avatar Sep 07 '22 23:09 siennathesane

Thanks for the PR, but the change seems to be incorrect -

when RTTMillisecond is 100 milliseconds and the election interval is expected to be 1 second, ElectionRTT should be 10.

lni avatar Oct 28 '22 07:10 lni

Is ElectionRTT a multiplier or a length of time? I can make the change, I just want to make sure I understand it.

siennathesane avatar Oct 29 '22 21:10 siennathesane

@lni would you be able to provide clarification on my previous question?

siennathesane avatar Dec 23 '22 23:12 siennathesane

Even though I am not @lni I think I can answer your question: ElectionRTT and HeartbeatRTT are both multipliers of RTTMillisecond.

coufalja avatar Dec 27 '22 08:12 coufalja

@coufalja is correct.

@mxplusb I had a quick look at the godoc in config/config.go, there are concrete examples on the definitions of both ElectionRTT and HeartbeatRTT. Would you like to have a look and provide feedback on whether it is still a little bit difficult to understand. Thanks.

lni avatar Dec 28 '22 05:12 lni