Costin Zaharia

Results 65 issues of Costin Zaharia

### Description After https://github.com/microsoft/codecoverage/issues/63 is included in a code coverage release, we should update the library and remove the workaround from [BinaryToXmlCoverageReportConverter.cs](https://github.com/SonarSource/sonar-scanner-msbuild/blob/master/src/SonarScanner.MSBuild.TFS.Classic/BinaryToXmlCoverageReportConverter.cs#L58-L61) to handle this corner case. See the comment...

Making blocking calls to async methods transforms code that was intended to be asynchronous into a blocking operation. Doing so can cause deadlocks and unexpected blocking of context threads.

CoverageReportDownloader and ICoverageReportDownloader are using strings instead of `Uri`. String representations of URIs or URLs are prone to parsing and encoding errors which can lead to vulnerabilities. The System.Uri class...

[Current example](https://docs.sonarsource.com/sonarqube/latest/devops-platform-integration/github-integration/#configuring-your-githubworkflowsbuildyml-file) only works on Windows. We need to: - store the snippet in a repository that we can easily maintain - create pipelines that can verify correctness - update...

Type: Tests

### Description Automatic coverage detection and conversion runs only for the .NET Framework package. See: https://github.com/SonarSource/sonar-scanner-msbuild/blob/6e58e9b26dc628af50098d6621f20272d3d9594c/src/SonarScanner.MSBuild.PostProcessor/PostProcessor.cs#L87-L89 Technically we can enable this for the .NET package too. We need to understand...

Type: UX

https://xtranet-sonarsource.atlassian.net/wiki/spaces/SSG/pages/1181769/Scanner+for+.NET+Release+Process Changes made: https://xtranet-sonarsource.atlassian.net/wiki/pages/diffpagesbyversion.action?pageId=1181769&selectedPageVersions=80&selectedPageVersions=76 Notes: - The scanner will update automatically for autoscan but the scanner-cli will not. We need add a note to manually update the scanner cli when...

PR on `re-ci-images` and `peachee-dotnet`: - https://github.com/SonarSource/re-ci-images/pull/391 - https://github.com/SonarSource/peachee-dotnet/pull/58 - https://github.com/SonarSource/re-ci-images/pull/410 - https://github.com/SonarSource/re-ci-images/pull/408 UPDATE: The changes of the two PR above require fixes: - https://github.com/SonarSource/peachee-dotnet/pull/71 - https://github.com/SonarSource/peachee-dotnet/pull/72 - https://github.com/SonarSource/peachee-dotnet/pull/73

Type: Task

### Description The [GitHub release task](https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/github-release-v1?view=azure-pipelines) fails when configured to use the inline release notes. Due to this we have configured the pipeline to use the version.txt instead, just to...

Area: Infrastructure

This file is generated by the SDK when you set PackAsTool to true, and normally, you do not need to create it yourself. Source: https://natemcmaster.com/blog/2018/05/12/dotnet-global-tools/ Since we decided to drop...

Type: Tooling

When doing the update please check that the number of executed ITs did not change, since the last attempt to update to `70.0` broke the test identification. See: https://dev.azure.com/sonarsource/DotNetTeam%20Project/_build/results?buildId=79239&view=logs&j=68cb23bd-4796-53e7-43bf-6da2c726740a&t=1b49fe1e-af63-58bd-9fcc-40e6806cc368 ![image](https://github.com/SonarSource/sonar-scanner-msbuild/assets/56015273/4a4b1371-e392-4fcc-ba30-82728dbdbeee)...

Type: Tests