Hiroshi Hatake

Results 409 comments of Hiroshi Hatake

Unit test should be passed even if the real AWS credentials are specified via environment variables. Currently, it will be failed when they are specified with environment variables.

Closing this in favor of https://github.com/fluent/fluent-bit/pull/6119

> cc: error: unrecognized command line option '-mindirect-branch-register' make[2]: *** [src/wasm/CMakeFiles/vmlib-static.dir/build.make:76: src/wasm/CMakeFiles/vmlib-static.dir///lib/wasm-micro-runtime-fast-jit-06-29-2022/core/shared/platform/linux/platform_init.c.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:6952: src/wasm/CMakeFiles/vmlib-static.dir/all] Error 2 Ah, that failures will be fixed by https://github.com/fluent/fluent-bit/pull/6036.

How about using this patch? WAMR does not support PPC64LE platform. (No mention for ppc64le on their cmake files and ours.) ```diff diff --git a/CMakeLists.txt b/CMakeLists.txt index d9531dc1d..8a4757daa 100644 ---...

Yes. Also needed similar patch for luajit: ```diff diff --git a/CMakeLists.txt b/CMakeLists.txt index d9531dc1d..9a0224525 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -907,8 +907,13 @@ endif() # LuaJIT (Scripting Support) # ==========================...

@sumitd2 Could you use this approach to detect ppc64le platform? https://github.com/cosmo0920/fluent-bit/commit/77f53a114b6b9410ffad262eb6eae331b298342b We should use the specific cmake file for ppc64le handling to keep maintanability.

Yup, we did break backward compatibility for derived Dockerfiles. Even if we don't include XML library, we have to add a note for XML library at least.

Creating dmg format installer is done by https://github.com/fluent-plugins-nursery/td-agent-builder/pull/192.

Creating Homebrew td-agent Formula task is also treated in this issue.

Registering td-agent dmg installer into [Homebrew Cask repository](https://github.com/Homebrew/homebrew-cask) is also needed to handle in this issue.