Hiroshi Hatake
Hiroshi Hatake
> @cosmo0920 pushed amended commit message for the commit linter like you suggested, see what the results are? Same error, so maybe someone can use this to adjust the linter?...
> @cosmo0920 adjusted back to two commit messages, one for `in_kubernetes_events:` and one for `tests:`, fingers crossed this works. Yeah, we did! Nice work. 😄 > Run python .github/scripts/commit_prefix_check.py ✅...
I found a potential issue but we could be skipped in this PR: ## Interaction with multiline + gzip (MEDIUM risk, but acceptable) There’s a subtle corner: Scenario: 1. Multi-member...
> Finally, should I add a note about the limitation (potential duplication on crash) to the documentation? I think adding a warning/note to the 'Database file' section would be helpful...
To merge this PR, we need to process reviewing process on fluent-bit repo at first. I added waiting-on-code-merge label to distinguish that it's not ready to merge this.
@eschabell I supressed vale errors on my written doc. How do we proceed further revising on this?
> only the calculated length determines message boundaries, and section 3.4.2 which specifies newline as the delimiter for non-transparent framing. Is that true? I mean the section 3.4.2 says: >...
> Perhaps the best option here is to (need your feedback) > > 1. Handle null bytes as delimiters when they're at the end of a complete syslog message >...
@eschabell Hi, this is not updating to reflect code changes. This describes the current limitation of Fluent Bit's configuration syntax of YAML. So, we can :shipit:!